Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipenv usage for repo #1868

Open
elreydetoda opened this issue Aug 19, 2020 · 0 comments · May be fixed by #14114
Open

Pipenv usage for repo #1868

elreydetoda opened this issue Aug 19, 2020 · 0 comments · May be fixed by #14114

Comments

@elreydetoda
Copy link
Contributor

Is your feature request related to a problem? Please describe.
No, but it has been mentioned in this issue: #1395

Describe the solution you'd like
I was curious if the project would be opposed if I submitted a pull request for generating files for using pipenv (i.e. Pipfile & Pipfile.lock), because you can still generate requirements.txt from those file (this command specifically: pipenv lock -r) but it also allows you to install dev packages. You could put ansible-lint, and if there are other, in there and then run pipenv install -d, and that will install all the normal dependencies and dev ones as well.

This would allow the project to contain all python dependencies, even for development, and could be used for a very portable and and more deterministic development/CI environments. This isn't required as you can see from these issues: #863 and #1554, but I think it would help make it more approachable as well as pipenv will manage virtual envs for the user instead of having to manually have them create it i.e.: step 4 in: https://github.com/trailofbits/algo#deploy-the-algo-server

Describe alternatives you've considered
Not really, and just curious specifically about pipenv, because I am not well versed in other package management tools.

Additional context
great video, by the author ( @ken-reitz ) of pipenv, talking about it and it's different features: https://youtu.be/GBQAKldqgZs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants