Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using pipenv for deps managment #11

Closed
elreydetoda opened this issue Jul 17, 2022 · 3 comments
Closed

Using pipenv for deps managment #11

elreydetoda opened this issue Jul 17, 2022 · 3 comments

Comments

@elreydetoda
Copy link
Collaborator

Hey @kbondarev,

Would you be open to possibly using pipenv vs just regular pip + freezing deps?

Similar to here where I made the case of using pipenv it's a lot easier way to manage your dependencies, and can add all your development dependencies in there as well (if you using pylint + black (or whatever linting + formatter you use)).

The other great thing you get out of using that is the inherit "freeze" via a .lock file, and it allows you to more easily upgrade things as well (via the pipenv update command (or via this)). It'll automatically handle setting up a virtual environment as well, or you can still have a local venv.

I've used it in GH actions before (thinkin about the JB website), so it works pretty well and even has a native GH action caching as well.

I'd happily make a PR to implement these changes (to both this repo + the main JB repo), but I just wanted to see what you thought about it first before doing that work 😅.

Good pipenv resources:

@kbondarev
Copy link
Collaborator

That's a good idea! Caching would reduce the time of the GH scraping action a little.

Personally, I'm a little bit more familiar with poetry. So naturally I'd prefer to use it instead of pipenv. But in the end I wouldn't mind pinenv either.
So... go ahead and setup either :)

@elreydetoda
Copy link
Collaborator Author

Yay 😁 , ya I've heard of poetry before and I've heard it's really good whenever you want to publish a package to pypi or any other python packaging place. (although I'm not super familiar with it to be honest)

Awesome, I'll get that taken care of then 😁 🚀

@elreydetoda
Copy link
Collaborator Author

closed by #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants