Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rule syntax version for all internal routers #10689

Merged
merged 1 commit into from May 15, 2024

Conversation

HalloTschuess
Copy link
Contributor

@HalloTschuess HalloTschuess commented May 4, 2024

What does this PR do?

This PR sets the rule syntax to v3 explicitly for dynamic.Router initialization for all internal routes.

Motivation

Fixes #10688

@traefiker traefiker added this to the 3.0 milestone May 4, 2024
@HalloTschuess HalloTschuess changed the title Set RuleSyntax "v3" for dynamic.Router explicitly Set rule syntax v3 for entrypoint redirections explicitly May 6, 2024
@HalloTschuess
Copy link
Contributor Author

HalloTschuess commented May 6, 2024

I previously added explicit RuleSyntax: "v3" for Kubernetes ingress routing here as well.

But as it turns out this would probably break the "workaround" for #10672. Therefore I reverted this change for now and only fixed the redirection.

The problem I tried to fix there was that buildHostRule uses the new syntax when the host begins with *.

@rtribotte rtribotte self-assigned this May 13, 2024
@HalloTschuess HalloTschuess changed the title Set rule syntax v3 for entrypoint redirections explicitly Fix rule syntax version for all internal routers May 13, 2024
Copy link
Member

@rtribotte rtribotte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rtribotte rtribotte removed their assignment May 14, 2024
@ldez
Copy link
Member

ldez commented May 15, 2024

You don't need to rebase, our bot will handle the rebase when the PR has 3 approvals.

Copy link
Member

@kevinpollet kevinpollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@traefiker traefiker merged commit d65de8f into traefik:v3.0 May 15, 2024
22 checks passed
@HalloTschuess HalloTschuess deleted the set-rule-syntax-explicitly branch May 15, 2024 09:13
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request May 24, 2024
https://build.opensuse.org/request/show/1176684
by user weberho + anag+factory
- Update to version 3.0.1
  * CVEs:
    * CVE-2024-24788 (bsc#1224018): A malformed DNS message in response to a
      query can cause the Lookup functions to get stuck in an infinite loop.
  * Bug fixes:
    * [k8s/ingress] Fix rule syntax version for all internal routers
      (gh#traefik/traefik#10689 by HalloTschuess)
    * [metrics,tracing] Allow empty configuration for OpenTelemetry metrics
      and tracing (gh#traefik/traefik#10729 by rtribotte)
    * [provider,tls] Bump tscert dependency to 28a91b69a046
      (gh#traefik/traefik#10668 by kevinpollet)
    * [rules,tcp] Fix the rule syntax mechanism for TCP
      (gh#traefik/traefik#10680 by lbenguigui)
    * [tls,server] Remove deadlines when handling PostgreSQL connections
      (gh#traefik/traefik#10675 by rtribotte)
    * [webui]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants