New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rule syntax version for all internal routers #10689
Fix rule syntax version for all internal routers #10689
Conversation
8108e61
to
5027714
Compare
I previously added explicit But as it turns out this would probably break the "workaround" for #10672. Therefore I reverted this change for now and only fixed the redirection. The problem I tried to fix there was that |
5027714
to
19bad2b
Compare
19bad2b
to
f9fd3d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f9fd3d1
to
26b85bd
Compare
You don't need to rebase, our bot will handle the rebase when the PR has 3 approvals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
Co-authored-by: romain <[email protected]>
26b85bd
to
0a75545
Compare
https://build.opensuse.org/request/show/1176684 by user weberho + anag+factory - Update to version 3.0.1 * CVEs: * CVE-2024-24788 (bsc#1224018): A malformed DNS message in response to a query can cause the Lookup functions to get stuck in an infinite loop. * Bug fixes: * [k8s/ingress] Fix rule syntax version for all internal routers (gh#traefik/traefik#10689 by HalloTschuess) * [metrics,tracing] Allow empty configuration for OpenTelemetry metrics and tracing (gh#traefik/traefik#10729 by rtribotte) * [provider,tls] Bump tscert dependency to 28a91b69a046 (gh#traefik/traefik#10668 by kevinpollet) * [rules,tcp] Fix the rule syntax mechanism for TCP (gh#traefik/traefik#10680 by lbenguigui) * [tls,server] Remove deadlines when handling PostgreSQL connections (gh#traefik/traefik#10675 by rtribotte) * [webui]
What does this PR do?
This PR sets the rule syntax to
v3
explicitly fordynamic.Router
initialization for all internal routes.Motivation
Fixes #10688