Chore: Updating devDependencies #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `eslint-plugin-jsdoc` which was preventing `npm install` when running Node v18+. #1142
Updating typescript dependency to match current Charting Library version. `ts-node` updated to ensure that the mocha tests can run.
Updating remaining dev dependencies (except eslint and related packages).
We cannot update `eslint-plugin-unicorn` because we need to remain on `eslint` v7 until this issue is resolved: eslint/eslint#14745 (which prevents `jsdoc/check-examples` rule from running)
Updating `typescript-eslint` to the latest version.
|
Dont see any reasons not to merge this PR. |
kirchet
reviewed
Aug 9, 2022
Bumped minimum required node version for development to `16.16.0`. Fix: `@types/node` changed to `16.11.47` which is the correct version for Node `16.16` CircleCI docker image version updated.
Fixes race condition on CI pipeline. `build` job requires website dependencies installed such that `@docusaurus/tsconfig` is installed before `tsc` is run.
Update CircleCI docker image to the 'next-gen convenience images' https://circleci.com/docs/next-gen-migration-guide
|
FYI: The existing CircleCI docker image For reference: |
kirchet
approved these changes
Aug 10, 2022
romfrancois
approved these changes
Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR: enhancement
npm installwith Node v18+ #1142 (ability to build project with node v18)4.7.3devDependenciesto the latest versions.Can’t be updated:
eslintandeslint-plugin-unicornneed to stay at the current versions because updating to v8 of eslint results injsdoc/check-examplesrule no longer running due to this issue: Allow processor API to be configurable and to formally be able to lint both a file and its blocks eslint/eslint#14745eslint-plugin-mdxcan’t be updated to v2 or later because it results in the linting task running indefinitely. The project makes heavy use of @example jsdocs thus it is important that these checks remain.Checks completed
npm run verifypassestypings.d.tsfiles remain identical.