Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've rethought the recent changes we've made in recent time to
fragments
. And I think I have good news: I think we can simplifyfragments
quite a lot.Reducible
s. Most of the combinators work sensibly even for the empty case, i.e.Foldable
sFragment
combinators that returnedOption[Fragment]
in the past, and they have been nothing but pain to work with. It's so so much better design to always return justFragment
fromFragment
combinators -- it's lower complexity and easier to work with for users.