Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manyNM and dependencies #8

Closed
wants to merge 2 commits into from
Closed

Conversation

aryairani
Copy link

added upToN and manyNM + tests. They require() n >= 0, m >= n.

changed manyN from foldLeft to recursive — could use a sanity check, will the trampolining in cons be enough to keep it from blowing the stack? Updated the test to try larger numbers (#7).

Because no longer using Range in manyN, manyN needs to require n >= 0; same with skipManyN which calls manyN. Updated both tests.

@tpolecat
Copy link
Owner

Hey sorry this took so long. Would you mind rebasing and reviewing your tests? I did a quick merge and manyNM was failing ... may have to do with the internals change although that would make me a little suspicious.

@aryairani
Copy link
Author

I don't mind at all, but I probably won't be able to look at it right away.

@tpolecat
Copy link
Owner

Thanks, no hurry at all.

@tpolecat
Copy link
Owner

I'm going to close this just to get it off the list, but feel free to reopen if you want to hack on it some more.

@tpolecat tpolecat closed this Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants