Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manyN combinator does unnecessary work on large n (relative to s) #7

Open
aryairani opened this issue Aug 17, 2014 · 0 comments
Open

manyN combinator does unnecessary work on large n (relative to s) #7

aryairani opened this issue Aug 17, 2014 · 0 comments

Comments

@aryairani
Copy link

...presumably because the foldLeft has to finish even when the parser is failing? Should fail-fast.
The unit test for manyN doesn't catch this, because it avoids large values of n.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aryairani