-
-
Notifications
You must be signed in to change notification settings - Fork 536
Log environment variables sorted by key while redacting values of unsafe ones #3543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
511fcac
to
7f508e0
Compare
@gaborbernat Any chance you could look at it again today? I think that I addressed the requests. This patch is a blocker for improving the security of GHA pipelines as I would not want to disable log collection for tox. Thanks. |
ca01304
to
37a1156
Compare
Please review again, I made the required changes, dropped the notice, added documentation entry, tested all keywords.
@gaborbernat Sorry to bother you again. Is there anything else I need to change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gaborbernat The py314 failure is unrelated and seems to be a bug in coveragepy. I will try to help @nedbat with a patch if I do not run out of time. That also made me realize that I need to fix few bugs in tox-uv in order to run coveragepy tests..., side effect raising tox-dev/tox-uv#210 |
@gaborbernat Any idea about what to do about py314 errors related to coverage?
They started to fail on main last night, so unrelated to this patch. Should we attempt to capture/hide these warnings to avoid our test failures? |
I think I will skip that warning on platforms where I don't ship a built wheel, though I'd be curious whether the installation of coverage on 3.14 shows that it tried to compile the extension or not? |
Coverage 7.9.1 is released to quiet that warning on 3.14. |
Improves logging of environment variables by sorting them by key and redacting the values for the ones that are likely to contain secrets.
Fixes: #3542
tox -e fix
)docs/changelog
folder