-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code pipeline #114
Open
gkpty
wants to merge
35
commits into
master
Choose a base branch
from
code_pipeline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Code pipeline #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ds. Also fixed the cloudfrontHostedZoneId which is actually the same for all regions and wasnt supposed to be an object.
…README2. renamed deleteSite renamed checkresource
…hods. Test for generateTemplate is passing. also refactored some of the DNS methods to the domains repo and some other methods
…in deployPart2. and need to move the deployStack method to the cli command
…seudo code into code
… the logical id is returned as the id property of the object
…d uploading content. need to test again. alos need to update scoped package.json and also need to add logs/cli to notify user of each step in the deployment process.
…tack comparisons and added come console logs into the deploystack command
Big refactoring 2
…ff is working sweet for godaddy domain
… partialtemplate with a full template
…ate generation issue in deployStack full vs partial. inserted process start and finish console logs
… aws provider requirement in the generateTemplate command
…o not import resources into stacks that already exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.