Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI mode #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add CLI mode #486

wants to merge 1 commit into from

Conversation

vrask
Copy link

@vrask vrask commented Aug 25, 2020

Add option to download and install Tor Browser using CLI

Resolves #39

@vrask vrask requested a review from micahflee as a code owner August 25, 2020 04:49
@vrask
Copy link
Author

vrask commented Sep 2, 2020

Pinging @intrigeri to humbly request a review

@intrigeri
Copy link
Collaborator

intrigeri commented Sep 2, 2020 via email

@vrask
Copy link
Author

vrask commented Sep 3, 2020

Hi,

Unfortunately, the only part of torbrowser-launcher that I'm
knowledgeable enough about to do hopefully-proper reviews about is the
AppArmor policy. I'm not familiar with the code base, so I'll pass.

Understood, saw you as the most active maintainer, but just read the .github/CODEOWNERS doc. Is @micahflee still active? If so, pinging to request a review (same humility level).

@rogers0
Copy link
Contributor

rogers0 commented Oct 7, 2020

@vrask Please kindly help to rebase to the latest. Thank you!

Add option to download and install Tor Browser using CLI
@vrask
Copy link
Author

vrask commented Oct 21, 2020

@vrask Please kindly help to rebase to the latest. Thank you!

No problem :)

Added the updates for socks5h to launcher_cli.py as well. I didn't see an easy way to do CLI mode in launcher.py, would it be better long-term to implement in that file? If so, I can work on it over the next week or two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gui-less mode
3 participants