Skip to content

Address colour contrast issues in the decorative caps#424

Merged
helenb merged 1 commit intomainfrom
feature/twe-690-decorative-caps-contrast-fixes
Mar 12, 2026
Merged

Address colour contrast issues in the decorative caps#424
helenb merged 1 commit intomainfrom
feature/twe-690-decorative-caps-contrast-fixes

Conversation

@helenb
Copy link
Copy Markdown
Member

@helenb helenb commented Mar 11, 2026

Link to Ticket

Description of Changes Made

  • Updated the affected decorative caps to use contrasting colours. In fact the comments above were correct and the actual colours in the CSV were wrong.

How to Test

You can test on the components page in the pattern library to review the different combinations

Search for 'fill' in the changed lines to see what is different.

Screenshots

See the ticket

MR Checklist

  • Add a description of your pull request and instructions for the reviewer to verify your work.
  • If your pull request is for a specific ticket, link to it in the description.
  • Stay on point and keep it small so the merge request can be easily reviewed.
  • Tests and linting passes.

Unit tests

  • Added
  • Not required

Documentation

Browser testing

  • I have tested in the following browsers and environments (edit the list as required)
    • Latest version of Chrome on mac
  • Not required

Data protection

  • Not relevant
  • This adds new sources of PII and documents it and modifies Birdbath processors accordingly

Light and dark mode

  • I have tested the changes in both light and dark mode
  • The change is not relevant to dark and light mode

Accessibility

  • Automated WCAG 2.1 tests pass
  • HTML validation passes
  • Manual WCAG 2.1 tests completed
  • I have tested in a screen reader
  • I have tested in high-contrast mode
  • Any animations removed for prefers-reduced-motion
  • Not required

Sustainability

  • Images are optimised and lazy-loading used where appropriate
  • SVGs have been optimised
  • Performance and transfer of data considered
  • If JavaScript is needed alternatives have been considered
  • Not required

Pattern library

  • The pattern library component for this template displays correctly, and does not break parent templates
  • The styleguide is updated if relevant
  • Changes are not relevant the pattern library

@helenb helenb marked this pull request as draft March 11, 2026 11:03
@helenb helenb force-pushed the feature/twe-690-decorative-caps-contrast-fixes branch from 25397e9 to f16ab74 Compare March 11, 2026 11:16
@helenb helenb marked this pull request as ready for review March 11, 2026 11:56
@helenb helenb requested review from chris-lawton March 11, 2026 15:03
Copy link
Copy Markdown
Member

@chris-lawton chris-lawton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Helen, tested locally and the updates pass colour contrast 👍🏻

@helenb helenb merged commit 165fb52 into main Mar 12, 2026
4 checks passed
@helenb helenb deleted the feature/twe-690-decorative-caps-contrast-fixes branch March 12, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants