Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tag overrides’ default_html preventing real tag usage #199

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thibaudcolas
Copy link
Member

@thibaudcolas thibaudcolas commented Jul 21, 2022

Description

This fixes a bug with our tag overrides’ support for default values. As implemented currently, we can no longer just let the tag render as normal – the default value would always take precedence, even if unset.

Even though this is a bug fix, I believe it might be sensible to only release this in a major version. Lots of projects might rely on the fact that tags always render None.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation Not needed
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • [ ] I have added an appropriate CHANGELOG entry Will do this once merged

@cclauss
Copy link
Contributor

cclauss commented Jan 16, 2024

This branch has conflicts that must be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants