Extend Bernoulli distribution to p=0 and p=1 #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, torch.bernoulli(p) requires 0 < p < 1. While this is strictly speaking mathematically correct, allowing in practice p = 0 and p = 1 to sample from the limit constant case is very convenient in many algorithms (eg. over-parametrization of a state space, where neurons can degenerate with a weight arbitrarily close to 0).
This tolerance for p=0 and p=1 is implemented in Matlab's Stat Toolbox's binornd(), as well as in the very useful Randraw package.
The attached patch implements this tolerance and documents it.