Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tidal source #256

Merged
merged 22 commits into from
Mar 20, 2025
Merged

Add Tidal source #256

merged 22 commits into from
Mar 20, 2025

Conversation

infnibor
Copy link
Contributor

@topi314
Copy link
Owner

topi314 commented Mar 15, 2025

since tidal is deprecating their v1 api this should be based on their v2 api

@topi314 topi314 closed this Mar 15, 2025
@topi314 topi314 reopened this Mar 15, 2025
@topi314
Copy link
Owner

topi314 commented Mar 15, 2025

after some reconsideration their v2 api looks quite ass, we will use v1 until it stops working

Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a bit of stuff wrong, can't merge like this

@topi314 topi314 added enhancement New feature or request new source Someone added a new source labels Mar 15, 2025
@infnibor
Copy link
Contributor Author

After making the changes, at least with me locally Build executed successfully
image

@infnibor infnibor requested a review from topi314 March 16, 2025 11:53
@topi314
Copy link
Owner

topi314 commented Mar 16, 2025

can you run auto format via intellij over this?
the .editorconfig exists for a reason

it might change some files which you didn't touch, just omit those from committing
I'll reformat them on master after your changes have been merged to avoid merge conflicts

@infnibor
Copy link
Contributor Author

can you run auto format via intellij over this? the .editorconfig exists for a reason

it might change some files which you didn't touch, just omit those from committing I'll reformat them on master after your changes have been merged to avoid merge conflicts

Done

@topi314 topi314 linked an issue Mar 18, 2025 that may be closed by this pull request
Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is prob fine

@topi314 topi314 merged commit 06b7cab into topi314:master Mar 20, 2025
@topi314
Copy link
Owner

topi314 commented Mar 20, 2025

please feel free to do a final tidal test once it's been built on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new source Someone added a new source
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tidal Support
2 participants