-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tidal source #256
Add Tidal source #256
Conversation
infnibor
commented
Mar 15, 2025
- Based on Tidal & Jiosaavn , Advanced mirroring #247 and corrections by Mintone-creators
- Based on topi314#247 and corrections by Mintone-creators
since tidal is deprecating their v1 api this should be based on their v2 api |
after some reconsideration their v2 api looks quite ass, we will use v1 until it stops working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a bit of stuff wrong, can't merge like this
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
can you run auto format via intellij over this? it might change some files which you didn't touch, just omit those from committing |
Done |
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalAudioTrack.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/tidal/TidalSourceManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is prob fine
please feel free to do a final tidal test once it's been built on master |