-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Qobuz Source Manager #254
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
auto format exist, use it
protocol/src/commonMain/kotlin/com/github/topi314/lavasrc/protocol/Config.kt
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/QobuzConfig.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioTrack.java
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
// throw new IllegalStateException("Failed to get track media URI"); | ||
} | ||
if (!json.get("sample").isNull() && json.get("sample").asBoolean(true) == true) { | ||
return getFallback(); | ||
// throw new IllegalStateException("Premium account required to play the whole | ||
// track"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is up with this commented code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getFallback()
uses a public api which allows to fetch stream urls from qobuz . Should i keep it or remove it ?
- Without qobuz premium account the api only returns 30 second previews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what kind of public api?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a music site, "music.wjhe.top," hosted by some Chinese people. That site supports playback from multiple sources, including Qobuz. The site uses the api to request streams that I added it here. Should I remove it?
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioTrack.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cba to add a comment for each blank line. please fix.
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Show resolved
Hide resolved
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioSourceManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds support for the Qobuz source by introducing a new Qobuz configuration, audio track implementation, and integrations into the plugin and documentation.
- Added a new QobuzConfig class for managing Qobuz-related properties.
- Implemented QobuzAudioTrack for handling Qobuz track media, including fallback mechanisms and signature generation.
- Updated plugin configuration and documentation (README.md) to include Qobuz source manager details.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/QobuzConfig.java | Adds configuration support for Qobuz. |
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioTrack.java | Implements Qobuz-specific audio track logic. |
README.md | Updates documentation for Qobuz integration and usage. |
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java | Integrates QobuzAudioSourceManager into the plugin. |
plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/SourcesConfig.java | Adds a flag to enable/disable Qobuz source support. |
No description provided.