Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Qobuz Source Manager #254

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

munishkhatri720
Copy link
Contributor

No description provided.

Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto format exist, use it

Comment on lines 59 to 65
// throw new IllegalStateException("Failed to get track media URI");
}
if (!json.get("sample").isNull() && json.get("sample").asBoolean(true) == true) {
return getFallback();
// throw new IllegalStateException("Premium account required to play the whole
// track");
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is up with this commented code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getFallback() uses a public api which allows to fetch stream urls from qobuz . Should i keep it or remove it ?

  • Without qobuz premium account the api only returns 30 second previews.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of public api?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a music site, "music.wjhe.top," hosted by some Chinese people. That site supports playback from multiple sources, including Qobuz. The site uses the api to request streams that I added it here. Should I remove it?

Copy link
Owner

@topi314 topi314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cba to add a comment for each blank line. please fix.

@topi314 topi314 requested a review from Copilot March 11, 2025 19:47
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for the Qobuz source by introducing a new Qobuz configuration, audio track implementation, and integrations into the plugin and documentation.

  • Added a new QobuzConfig class for managing Qobuz-related properties.
  • Implemented QobuzAudioTrack for handling Qobuz track media, including fallback mechanisms and signature generation.
  • Updated plugin configuration and documentation (README.md) to include Qobuz source manager details.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/QobuzConfig.java Adds configuration support for Qobuz.
main/src/main/java/com/github/topi314/lavasrc/qobuz/QobuzAudioTrack.java Implements Qobuz-specific audio track logic.
README.md Updates documentation for Qobuz integration and usage.
plugin/src/main/java/com/github/topi314/lavasrc/plugin/LavaSrcPlugin.java Integrates QobuzAudioSourceManager into the plugin.
plugin/src/main/java/com/github/topi314/lavasrc/plugin/config/SourcesConfig.java Adds a flag to enable/disable Qobuz source support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants