Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure awaits in RedistributableLocator to continue on any thread #345

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions src/CSnakes.Runtime/Locators/RedistributableLocator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -163,13 +163,18 @@ protected override string GetLibPythonPath(string folder, bool freeThreaded = fa
private static async Task<string> DownloadFileToTempDirectoryAsync(string fileUrl)
{
using HttpClient client = new();
using var contentStream = await client.GetStreamAsync(fileUrl);

string tempFilePath = Path.GetTempFileName();
using FileStream fileStream = new FileStream(tempFilePath, FileMode.Create, FileAccess.Write, FileShare.None);
await contentStream.CopyToAsync(fileStream);
var contentStream = await client.GetStreamAsync(fileUrl).ConfigureAwait(false);
await using (contentStream.ConfigureAwait(false))
{
string tempFilePath = Path.GetTempFileName();
var fileStream = new FileStream(tempFilePath, FileMode.Create, FileAccess.Write, FileShare.None);
await using (fileStream.ConfigureAwait(false))
{
await contentStream.CopyToAsync(fileStream).ConfigureAwait(false);
}

return tempFilePath;
return tempFilePath;
}
}

private static string DecompressZstFile(string zstFilePath)
Expand Down
Loading