Add secondary subtitles command

[leiserfg]

No description provided.

[leiserfg]

Implements #504

[hooke007]

It think it should be optimized more. Both of two menus look the same.

[christoph-heinrich]

Imo it would be best if subtitles and secondary subtitles use the same menu. The secondary subtitle could be selected while holding shift or something, but then we also need a way of visually differentiating between them.

[hooke007]

shift was already binded, ALT would be better.

[tomasklaen]

Yes, it does make sense to make it part of the existing subtitles menu. It'll require the menu key events API change I've been planning for a while now.

We can use counter_1 and counter_2 icons to differentiate the two.

[gunir]

Currently I'm using another icon with above patch to use secondary subtitle, but I think having dual subs is great because:

• It helps language learning
• It helps comparing 2 subttiles
• It's just great to have

But I think 1 single icon with 2 subtitle menus is better, but we need to add another submenu inside the current subtitle menu to switch to secondary submenu:

[k1gen]

bump. I'm learning German, and dual subs is a great feature I'd love to have in uosc

[azizLIGHT]

Currently I'm using another icon with above patch to use secondary subtitle, but I think having dual subs is great because:

• It helps language learning
• It helps comparing 2 subttiles
• It's just great to have

But I think 1 single icon with 2 subtitle menus is better, but we need to add another submenu inside the current subtitle menu to switch to secondary submenu:

How were you able to do this? I added the changed lines from this PR to scripts/uosc/main.lua:

bind_command('subtitles-2', create_select_tracklist_type_menu_opener(
	'Secondary Subtitles', 'sub', 'secondary-sid', 'script-binding uosc/load-subtitles'
))

and added subtitles-2 to script-opts/uosc.conf

controls=menu,gap,subtitles,subtitles-2,<has_many_audio>audio...

But my uosc menu fails to load all buttons after the primary subtitle button, indicating a failure

[azizLIGHT]

I figured out how to do it. As my in my previous comment, put into scripts/uosc/main.lua:

bind_command('secondary-subtitles', create_select_tracklist_type_menu_opener(
	t('Secondary Subtitles'), 'sub', 'secondary-sid', 'script-binding uosc/load-subtitles', 'script-binding uosc/download-subtitles'
))

But then put this in script-opts/uosc.conf:

controls=menu,gap,subtitles,command:subtitles:script-binding uosc/secondary-subtitles?Secondary Subtitles,<has_many_audio>audio,<has_many_video>video,<has_many_edition>editions,<stream>stream-quality,gap,space,<has_chapter>command:arrow_back_ios:no-osd add chapter -1?Previous Chapter,command:fast_rewind:seek -10?Rewind 10s,cycle:play_arrow:pause:no=pause/yes=play_arrow?Play/Pause,command:fast_forward:seek 10?Forward 10s,<has_chapter>chapters,<has_chapter>command:arrow_forward_ios:no-osd add chapter 1?Next Chapter,space,speed,space,shuffle,loop-playlist,loop-file,gap,prev,items,next,gap,fullscreen

The important part is command:subtitles:script-binding uosc/secondary-subtitles?Secondary Subtitles