Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OWASP Java Encoder #151

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremylong
Copy link
Contributor

The OWASP Java Encoder is a high performance encoding library. While I understand this is adding a dependency - the encoder project itself has not dependencies and is a very stable library.

@tomasbjerre
Copy link
Owner

If the tripple brackets solves this, the PR can be closed:
tomasbjerre/violation-comments-lib#22 (comment)

Or else, I think this library needs to be relocated in the build.gradle:

project.ext.buildConfig = [
  publishing: [
    relocate: [
      'com.google',
      'com.jakewharton',
      'org.owasp'
    ]
  ],

@jeremylong
Copy link
Contributor Author

Thank you for pointing out the triple bracket syntax. Yes, that solves my current issue. However, this PR was not specifically to fix the newline issue I was having. While yes, it does introduce a new library - the library is faster, compliant with the RFC, and does not have any transitive dependencies. But I also understand the desire to use fewer libraries. Totally fine if you don't want to introduce a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants