Release v1.0.3 #1843
Merged
Release v1.0.3 #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @stlankes |
The old target is removed from newest rustc versions.
Rust's standard library currently doesn't build.
Lifetimes can serve as helpful documentation.
Darksonn
approved these changes
Nov 29, 2024
Comment on lines
+3
to
+9
| * Implement more I/O safety traits | ||
| (https://github.com/tokio-rs/mio/pull/1831). | ||
| * Remove hermit-abi dependency, now using libc | ||
| (https://github.com/tokio-rs/mio/pull/1830). | ||
| * Use `poll(2)` implementation on AIX, removing the need for using | ||
| `mio_unsupported_force_poll_poll` | ||
| (https://github.com/tokio-rs/mio/pull/1833). |
There was a problem hiding this comment.
Up to you, but I'd have made a minor release rather than a patch release for this.
There was a problem hiding this comment.
Maybe, I don't really care about minor vs. patch, as long as it's not breaking :)
There was a problem hiding this comment.
I make almost everything a minor release since it gives me space to do backports. With patch releases, there's no version number between two releases.
There was a problem hiding this comment.
Fair. For Mio we don't have that many changes so I haven't needed it yet.
Can't build standard lib.
|
I didn't change any code and somehow Clippy found more warnings after I disabled a lint. |
|
That's probably due to the 1.83 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.