functions.sh: make IFB interface name configurable #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept a new variable `$IFB_PATTERN` which is used as a printf(1) pattern to generate the IFB interface name from the primary interface name. The default is `ifb4%s` which corresponds to the pre-existing behavior. Signed-off-by: Ivan Shapovalov <[email protected]>
Collaborator
|
Out of curiosity, what is the motivation for this? |
Author
Some less-than-configurable monitoring software that uses hardcoded patterns of ignored interface names. There is a pattern for ifb interfaces, but it does not match |
Collaborator
|
Fair, may I ask to maybe add this to the commit description (maybe even reveal that monitoring software's name)? So far the fixed naming for sqm created IFBs has helped in the past to detect cases where users accidentally tried multiple traffic shaping solutions in parallel... |
Owner
|
Yes, please document the reason for the change in the commit message :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept a new variable
$IFB_PATTERNwhich is used as a printf(1)pattern to generate the IFB interface name from the primary interface
name. The default is
ifb4%swhich corresponds to the pre-existingbehavior.
Signed-off-by: Ivan Shapovalov [email protected]