Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(component): confirm modal should not clip content #8325

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Sep 20, 2024

close AF-1050

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @CatsJuice and the rest of your teammates on Graphite Graphite

@CatsJuice CatsJuice marked this pull request as ready for review September 20, 2024 06:48
Copy link

nx-cloud bot commented Sep 20, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.77%. Comparing base (ec7c630) to head (87983c0).
Report is 2 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8325      +/-   ##
==========================================
+ Coverage   72.71%   72.77%   +0.05%     
==========================================
  Files         519      519              
  Lines       32899    32899              
  Branches     2866     2866              
==========================================
+ Hits        23924    23942      +18     
+ Misses       8944     8926      -18     
  Partials       31       31              
Flag Coverage Δ
server-test 78.95% <ø> (+0.06%) ⬆️
unittest 49.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

  • Sep 20, 3:06 AM EDT: forehalo added this pull request to the Graphite merge queue.
  • Sep 20, 3:27 AM EDT: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: '3, 2, 1 Launch', 'E2E Mobile Test (1)').

@forehalo forehalo force-pushed the catsjuice/fix/comfirm-modal-clip-issue branch from 5202a6e to 87983c0 Compare September 20, 2024 07:16
@forehalo forehalo enabled auto-merge (squash) September 20, 2024 07:35
@forehalo forehalo merged commit c87a392 into canary Sep 20, 2024
38 checks passed
@forehalo forehalo deleted the catsjuice/fix/comfirm-modal-clip-issue branch September 20, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants