Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): use openExternal in electron #8323

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(core): use openExternal in electron #8323

merged 1 commit into from
Sep 20, 2024

Conversation

forehalo
Copy link
Member

No description provided.

Copy link

graphite-app bot commented Sep 20, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @forehalo and the rest of your teammates on Graphite Graphite

Copy link

nx-cloud bot commented Sep 20, 2024

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.71%. Comparing base (8d4cc6a) to head (ec7c630).
Report is 1 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8323      +/-   ##
==========================================
- Coverage   72.77%   72.71%   -0.06%     
==========================================
  Files         519      519              
  Lines       32899    32899              
  Branches     2866     2866              
==========================================
- Hits        23942    23924      -18     
- Misses       8926     8944      +18     
  Partials       31       31              
Flag Coverage Δ
server-test 78.88% <ø> (-0.07%) ⬇️
unittest 49.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Sep 20, 2024

Merge activity

@graphite-app graphite-app bot merged commit ec7c630 into canary Sep 20, 2024
38 checks passed
@graphite-app graphite-app bot deleted the 61/popup branch September 20, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants