feat: history timeline shows relative time, such as today and yesterday #6864
+196
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into canaryAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
mod:i18n
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 261d413. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
akumatus
changed the title
akumatus
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #6864 +/- ##
==========================================
+ Coverage 66.64% 66.65% +0.01%
==========================================
Files 582 582
Lines 27169 27184 +15
Branches 2529 2535 +6
==========================================
+ Hits 18106 18119 +13
- Misses 8795 8797 +2
Partials 268 268
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
akumatus
force-pushed
the
feat/history-version-with-calendar-date
branch
from
a6860dd
to
37f09de
Compare
pengx17
approved these changes
May 10, 2024
akumatus
force-pushed
the
feat/history-version-with-calendar-date
branch
5 times, most recently
from
5c662be
to
018a234
Compare
akumatus
force-pushed
the
feat/history-version-with-calendar-date
branch
2 times, most recently
from
e4d9a55
to
870bf20
Compare
Brooooooklyn
approved these changes
May 13, 2024
Merge activity
|
…ay (#6864) ### TL;DR First, fixed an i18n issue in history panel. When the browser language is set to Chinese, and the AFFiNE application language is set to English, the language supposed to be English global. But now the language is a mixture of Chinese and English, which is obviously wrong.  Second, design a time formatter to convert timestamp into relative calendar date, such today and yesterday and so on. Long-ago edits will show the exact date like before.  ### What changed? - `new Intl.DateTimeFormat` with language option form `document.documentElement.lang` - Added `timestampToCalendarDate` function to convert timestamp into relative calendar date - Updated unit tests - Updated i18n copywriting ### How to test? 1. Open view history version 2. Check edit timeline
Brooooooklyn
force-pushed
the
feat/history-version-with-calendar-date
branch
from
870bf20
to
261d413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
First, fixed an i18n issue in history panel. When the browser language is set to Chinese, and the AFFiNE application language is set to English, the language supposed to be English global. But now the language is a mixture of Chinese and English, which is obviously wrong.
Second, design a time formatter to convert timestamp into relative calendar date, such today and yesterday and so on. Long-ago edits will show the exact date like before.
What changed?
new Intl.DateTimeFormatwith language option formdocument.documentElement.langtimestampToCalendarDatefunction to convert timestamp into relative calendar dateHow to test?