Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): disable micromark debug output #6528

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Apr 11, 2024

No description provided.

Copy link

graphite-app bot commented Apr 11, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

Copy link
Collaborator Author

pengx17 commented Apr 11, 2024

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 61.65%. Comparing base (4a67c84) to head (8769aef).

Files Patch % Lines
packages/common/debug/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                  Coverage Diff                                  @@
##           04-11-fix_core_chat_panel_display_on_cont_in_chat    #6528      +/-   ##
=====================================================================================
+ Coverage                                              61.58%   61.65%   +0.06%     
=====================================================================================
  Files                                                    526      526              
  Lines                                                  25880    25880              
  Branches                                                2326     2327       +1     
=====================================================================================
+ Hits                                                   15939    15957      +18     
+ Misses                                                  9667     9649      -18     
  Partials                                                 274      274              
Flag Coverage Δ
server-test 71.74% <ø> (+0.10%) ⬆️
unittest 38.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the 04-11-fix_core_chat_panel_display_on_cont_in_chat branch from 46d04f0 to c1153b2 Compare April 11, 2024 11:16
@pengx17 pengx17 force-pushed the 04-11-fix_core_disable_micromark_debug_output branch from 5916adc to e358c2b Compare April 11, 2024 11:16
@pengx17 pengx17 force-pushed the 04-11-fix_core_chat_panel_display_on_cont_in_chat branch from c1153b2 to 7742c3f Compare April 11, 2024 12:04
@pengx17 pengx17 force-pushed the 04-11-fix_core_disable_micromark_debug_output branch from e358c2b to e6f2ecf Compare April 11, 2024 12:04
Copy link

perfsee bot commented Apr 11, 2024

affine-toeverything

Bundle main

diff ------------------- Bundle Size Diff -------------------------

@@                        EntryPoint: app                        @@
##                     master …_debug_output                 +/- ##
===================================================================
  Bundle                    ?        18.8 MB                       
  Initial JS                ?        6.85 MB                       
  Initial CSS               ?         103 kB                       
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~#
  Assets                    ?            107                       
  Chunks                    ?            105                       
  Packages                  ?            293                       
< Duplicates                0             12                 +12   
#~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Warnings ~~~~~~~~~~~~~~~~~~~~~~~~~~~#
! Deduplicate versions of libraries                                
! Split assets into smaller pieces                                 
! Avoid large JavaScript libraries with smaller alternatives       
! Separate mixed content assets files                              
! Improve page load speed with `preconnect` or `dns-prefetch`      
! Avoid cache wasting                                              

@EYHN EYHN force-pushed the 04-11-fix_core_chat_panel_display_on_cont_in_chat branch from 7742c3f to bdaa7e4 Compare April 12, 2024 03:31
@EYHN EYHN force-pushed the 04-11-fix_core_disable_micromark_debug_output branch from e6f2ecf to b4ca8df Compare April 12, 2024 03:31
@EYHN EYHN force-pushed the 04-11-fix_core_chat_panel_display_on_cont_in_chat branch from bdaa7e4 to f47829f Compare April 12, 2024 03:39
@EYHN EYHN force-pushed the 04-11-fix_core_disable_micromark_debug_output branch from b4ca8df to dd39294 Compare April 12, 2024 03:39
Copy link

graphite-app bot commented Apr 12, 2024

Merge activity

@EYHN EYHN force-pushed the 04-11-fix_core_chat_panel_display_on_cont_in_chat branch from f47829f to 4a67c84 Compare April 12, 2024 04:01
@EYHN EYHN force-pushed the 04-11-fix_core_disable_micromark_debug_output branch from dd39294 to 8769aef Compare April 12, 2024 04:01
@EYHN EYHN changed the base branch from 04-11-fix_core_chat_panel_display_on_cont_in_chat to canary April 12, 2024 04:15
@graphite-app graphite-app bot merged commit 8769aef into canary Apr 12, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 04-11-fix_core_disable_micromark_debug_output branch April 12, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants