Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(server): dont convert graphql bad request into internal server error #10203

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Feb 15, 2025

No description provided.

@fengmk2 fengmk2 requested review from Brooooooklyn, forehalo and a team February 15, 2025 06:28
@github-actions github-actions bot added app:server test Related to test cases labels Feb 15, 2025
Copy link
Member Author

fengmk2 commented Feb 15, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@fengmk2 fengmk2 marked this pull request as ready for review February 15, 2025 06:28
@graphite-app graphite-app bot requested a review from a team February 15, 2025 06:28
Copy link

codecov bot commented Feb 15, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 54.04%. Comparing base (34472fd) to head (5721378).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
.../backend/server/src/__tests__/utils/testing-app.ts 57.14% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10203   +/-   ##
=======================================
  Coverage   54.04%   54.04%           
=======================================
  Files        2327     2327           
  Lines      107036   107082   +46     
  Branches    17738    17744    +6     
=======================================
+ Hits        57845    57874   +29     
- Misses      47872    47889   +17     
  Partials     1319     1319           
Flag Coverage Δ
server-test 78.29% <90.19%> (-0.02%) ⬇️
unittest 31.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fengmk2 fengmk2 force-pushed the 02-15-refactor_server_dont_convert_graphql_bad_request_into_internal_server_error branch from 52fcb96 to e3720c4 Compare February 17, 2025 02:00
Copy link

graphite-app bot commented Feb 17, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-15-refactor_server_dont_convert_graphql_bad_request_into_internal_server_error branch from e3720c4 to 5721378 Compare February 17, 2025 06:17
@graphite-app graphite-app bot merged commit 5721378 into canary Feb 17, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-15-refactor_server_dont_convert_graphql_bad_request_into_internal_server_error branch February 17, 2025 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants