-
Notifications
You must be signed in to change notification settings - Fork 126
Update book content with updated Vale rules #654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jan van den Berg <[email protected]>
Signed-off-by: Jan van den Berg <[email protected]>
✅ Deploy Preview for ospobook ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ospomindmap canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates - the em-dash rule is still creating a few issues, as is the rule about hyphenating adverbs. I can update the writing style guide to tackle the latter.
You are totally right, let me check my style locally and/or fix the issue. |
Signed-off-by: Jan van den Berg <[email protected]>
Signed-off-by: Jan van den Berg <[email protected]>
Corrections for `supply-side` and `early-stage`. Co-authored-by: Alice Sowerby <[email protected]> Signed-off-by: Jan van den Berg <[email protected]>
Thanks again @alice-sowerby, it should be correct now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! @koozz thank you.
This pull request primarily focuses on improving the readability and consistency of the OSPO book content by addressing grammar, formatting, and terminology issues. Additionally, it includes a minor configuration change in the
.vale
linting rule. Below is a summary of the most important changes grouped by theme.Grammar and Style Improvements:
ospo-book/content/en/02-chapter.md
,ospo-book/content/en/03-chapter.md
,ospo-book/content/en/04-chapter.md
,ospo-book/content/en/toc.md
). [1] [2] [3] [4]ospo-book/content/en/02-chapter.md
.Code and Formatting Adjustments:
xz/liblzma
in backticks for consistency with markdown formatting inospo-book/content/en/02-chapter.md
. [1] [2]ospo-book/content/en/05-chapter.md
.Linting Configuration Change:
.vale
linting configuration to change thescope
fromraw
tosentence
, to improve the accuracy and exclude MarkDown tables of linting checks in.vale/TODO/EmDashes.yml
.Terminology Refinements:
ospo-book/content/en/03-chapter.md
.ospo-book/content/en/06-chapter.md
.Fixes: #556