Fix Makefile race conditions. #520
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two race conditions in `libtock-rs`' Makefile: 1. Running e.g. `make -j2 hail flash-hail EXAMPLE=console` will cause concurrent `cargo run` invocations that race. 2. Running `make -j2 test` with a missing toolchain can result in parallel toolchain installs, which corrupts the toolchain. I also fixed `make clean`, which wasn't cleaning up the nightly toolchain's target file.
jrvanwhy
added
the
upkeep
alistair23
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two race conditions in
libtock-rs' Makefile:make -j2 hail flash-hail EXAMPLE=consolewill cause concurrentcargo runinvocations that race (another variant of #366). This was fixed by changing the target directories for theflash-*targets.make -j2 testwith a missing toolchain can result in parallel toolchain installs, which corrupts the toolchain.I also fixed
make clean, which wasn't cleaning up the nightly toolchain's target directory.