-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tsql): Support for stored procedure options #4260
feat(tsql): Support for stored procedure options #4260
Conversation
Hi @rsanchez-xtillion, is this ready for review? What's pending? |
It is ready for review now, I was making sure the checks passed and added a description. |
Appreciate it, thanks. Will take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks a lot for the PR. Just a few minor comments to refactor this a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @rsanchez-xtillion, thank you for your patience & appreciate the quick iteration.
Added support for transact sql stored procedure options. Example:
I added support by:
WithStoredProcedureOptions
property expressionOPTIONS_TYPE
for the possible stored procedure options and for theEXECUTE AS
clause_parse_function_parameter
in the TSQL dialect