ResultSet#each and Statement#each should splat record passed to block #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Stmt#each If the record is not splatted, a block that processes a result set that contains a single column receives the column as an array with a single value. The problem is demonstrated by many of the tests that already existed, so no new tests are provided with this commit. Instead, all of the tests that demonstrated this problem have been updated so that queries returning a single column use the value of that column without wrapping it in an array.
tmtm
force-pushed
the
master
branch
3 times, most recently
from
a05cc94 to
b367feb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on tag 2.9.9. Github is not allowing a tag to be specified as the base branch.
If the record is not splatted, a block that processes a result set that
contains a single column receives the column as an array with a single value.
The problem is demonstrated by many of the tests that already existed, so no
new tests are provided with this commit. Instead, all of the tests that
demonstrated this problem have been updated so that queries returning a single
column use the value of that column without wrapping it in an array.