Replace active wait loop with a sleep in the Query thread. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional on line 500 ( if (thisNow > nextQueryMillis) {... ) is executed in a tight loop, so if the next query time isn't reached yet, the condition is immediately tested again. By default, the time between query intervals is 15 seconds. If the number of queries attempted per interval is relatively small, the amount of time the query thread spins on the conditional will eat cpu resources and distort the results.
This pull request replaces the active wait with a precisely calculated sleep. In addition, unused imports are remove.