Add "alloc" feature #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In a doc test, `#[test]`s are not executed. This change makes sure the tests are executed by removing the `#[test]` annotation. Also, the doc test is gated in `#[cfg(feature = "std"]`, because it uses `Box`es.
The library does not actually need any features found in `std`. Using `alloc` will suffice. The feature `std` is not removed, so the library: * remains backward compatible to downstream users who explicitly use `features = ["std"]`, * remains forward compatible in case you want to / need to depend on features only found in `std` at a later time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a doc test,
#[test]s are not executed. This change makes sure the tests are executed by removing the#[test]annotation. Also, the doc test is gated in#[cfg(feature = "std"], because it usesBoxes.The library does not actually need any features found in
std. Usingallocwill suffice. The featurestdis not removed, so the library:features = ["std"],stdat a later time.