Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use pydantic-compat library #213

Merged
merged 11 commits into from
Sep 24, 2023
Merged

build: use pydantic-compat library #213

merged 11 commits into from
Sep 24, 2023

Conversation

tlambert03
Copy link
Owner

@tlambert03 tlambert03 commented Aug 1, 2023

I pulled out most of the pydantic cross-compatibility stuff that I added in #205 (along with stuff I did for useq-schema and psygnal), and make a new library: https://github.com/tlambert03/pydantic-compat

this PR uses it and pulls out most of the patch logic here

this also includes and closes #220
it also pins xmlschema in tests... see #221

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Merging #213 (3ec4e8a) into main (1b31ab1) will decrease coverage by 0.37%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #213      +/-   ##
==========================================
- Coverage   86.48%   86.11%   -0.37%     
==========================================
  Files          26       26              
  Lines        1250     1217      -33     
==========================================
- Hits         1081     1048      -33     
  Misses        169      169              
Files Changed Coverage Δ
src/ome_autogen/_generator.py 100.00% <ø> (ø)
src/ome_autogen/main.py 100.00% <ø> (ø)
src/ome_types/_conversion.py 95.87% <100.00%> (-0.03%) ⬇️
src/ome_types/_mixins/_base_type.py 93.82% <100.00%> (-0.15%) ⬇️
src/ome_types/_mixins/_kinded.py 100.00% <100.00%> (ø)
src/ome_types/_mixins/_ome.py 97.91% <100.00%> (-0.05%) ⬇️
src/ome_types/_pydantic_compat.py 97.29% <100.00%> (-1.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 1, 2023

CodSpeed Performance Report

Merging #213 will not alter performance

Comparing pydantic-compat (3ec4e8a) with main (1b31ab1)

Summary

✅ 9 untouched benchmarks

@tlambert03 tlambert03 merged commit 9953d34 into main Sep 24, 2023
@tlambert03 tlambert03 deleted the pydantic-compat branch September 24, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant