-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: use pydantic-compat library #213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #213 +/- ##
==========================================
- Coverage 86.48% 86.11% -0.37%
==========================================
Files 26 26
Lines 1250 1217 -33
==========================================
- Hits 1081 1048 -33
Misses 169 169
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CodSpeed Performance ReportMerging #213 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I pulled out most of the pydantic cross-compatibility stuff that I added in #205 (along with stuff I did for useq-schema and psygnal), and make a new library: https://github.com/tlambert03/pydantic-compat
this PR uses it and pulls out most of the patch logic here
this also includes and closes #220
it also pins xmlschema in tests... see #221