Allow to specify the TinyPilot version identifier #1871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of https://github.com/tiny-pilot/tinypilot-pro/pull/1474, specifically https://github.com/tiny-pilot/tinypilot-pro/pull/1474#issuecomment-2725155594.
This PR modifies the interface of the
build-debian-pkgdev script so that it takes on multiple (optional) named flags, instead of just one (optional) position argument:--build-targetsflag replaces the previous positional input argument.--tinypilot-versionnow allows to set the version of the Debian package.git describe --tagscommand. We can still use it as implicit default, though. In Pro, we can then explicitly pass in the version identifier from the CircleCI build context – without, however, by directly making thebuild-debian-pkgscript depend on the CircleCI context, e.g. by referencing theCIRCLE_TAGenvironment variable inside ofbuild-debian-pkg.When inspecting the parameters of the actual build, the changes appear to work fine:
--platform linux/arm/v7 --build-arg TINYPILOT_VERSION=1.9.5-11+7fae51d(this PR)--platform linux/arm/v7 --build-arg TINYPILOT_VERSION=1.9.5-8+b6f3eb0(latest master)