Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄Change Play Button #1855

Merged
merged 3 commits into from
Sep 3, 2024
Merged

💄Change Play Button #1855

merged 3 commits into from
Sep 3, 2024

Conversation

joshbermanssw
Copy link
Collaborator

@joshbermanssw joshbermanssw commented Jun 17, 2024

The current youtube play button on the home page sucks, lets fix that!

#2143

cc: @bettybondoc @landonmaxwell @bradystroud

re: 🦙Tina.io - youtube/play button replace

As per our conversation with Betty, I want to swap the play button for one that matches the Tina style more (and has been ✅ test passed by Betty).

  1. Replace the current round play button with the svg here: [play-button-svg]
  2. Make it a bit bigger than the current button
  3. Vertically centre to the image
  4. Get test passed by Betty & Landon

This PR aims to address this

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
tina-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 3:25pm

@joshbermanssw
Copy link
Collaborator Author

new-youtube-btn.mov

after review with @sethdaily @adamcogan @jean

Figure: Updated Youtube Button

@sethdaily
Copy link
Contributor

@bettybondoc
FYI I gave this a Test Pass

@sethdaily sethdaily enabled auto-merge (squash) September 3, 2024 16:31
@sethdaily sethdaily merged commit 78cdb24 into main Sep 3, 2024
4 checks passed
@sethdaily sethdaily deleted the replace-play-button-img branch September 3, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants