Added the option to show a delete confirmation modal #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoKrus
reviewed
May 11, 2025
Comment on lines
+138
to
+139
| cancelButton = Stornieren | ||
| deleteConfirmation = Sind Sie sicher, dass Sie diesen Datei löschen möchten? |
There was a problem hiding this comment.
Suggested change
| cancelButton = Stornieren | |
| deleteConfirmation = Sind Sie sicher, dass Sie diesen Datei löschen möchten? | |
| cancelButton = Abbrechen | |
| deleteConfirmation = Bist du dir sicher, dass du diese Datei löschen möchtest? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks a lot for continuing this great project, it's nice to have the ability to self-host well built services.
Somehow some of my users have problems with accidentally deleting uploads, so I added the ability to show a confirmation modal, which looks like this:
It is disabled by default but can be enabled by setting
SHOW_DELETE_CONFIRMtotrue.I added translations for English, Dutch and German. How should we handle getting the rest?
Let me know if there are any changes I still need to make.
Thanks in advance,
Abe