-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
L10n fr #87
Merged
Merged
L10n fr #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Hello world, HOF, map, filter, every/some, reduce)
Oh wow. Thank you. |
timoxley
added a commit
that referenced
this pull request
Apr 16, 2015
Thanks again! Amazing work. |
Hey Tim, Glad you liked it! Thanks for the merge and version bump! |
❤️ |
This was referenced Apr 17, 2015
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Tim!
First, gratz on this cool workshop.
As part of the nodeschool/organizers#64 g11n effort currently underway, I'm bringing all workshopper-based workshops up to snuff on the latest versions of it so they can get translated (L10n) readily.
I'm also bringing them on the latest versions of their tested libs, and re-testing all the exercises, to reduce the risk of obsolescence.
This PR both upgrades the infra and provides FR L10n with third-party proofreading already baked in. I hope you see this favorably. We're hosting regular Paris NodeSchool sessions, and it would be fantastic if this could all be merged in and bumped in npm soon 😄
I am, of course, available for all questions and discussions on this.
Best,