Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update of LiveTile Control to allow the usage ot DataTemplateSelector #225

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

stumpyfr
Copy link

update of LiveTile Control to allow the usage of DataTemplateSelector, not the perfect integration but it's working and useful.

With the current datacontext logic, Its not possible to apply a DataContentSelector. To fix that, I call manually the DataTemplateSelector after each switch on the current and next item.

It's working and allows the creation of many different ContentTemplate in a easy way.

The fix answers the issue #221

…, not the perfect integration but working and useful
@dotMorten
Copy link
Collaborator

I think this is a neat idea. A few comments to the pull request:
I don't think the ContentTemplateSelector binding in generic.xaml is needed (code is used to select templates, and I think this might cause it to be hit twice). If it is needed, I would have some concern wrt to breaking any users who have custom templates already.

I would skip the sample and keep it the simple way, to avoid confusion for the general case.

I think the only code really needed is the bit in LiveTile.cs

@stumpyfr
Copy link
Author

Oh my....yes the ContentTemplateSelector Binding isn't needed anymore...was my first test :/.
My mistake, we can delete that binding, everything is done in the code now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants