Allow replica identity on compressed hypertables #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesGuthrie
force-pushed
the
jg/replident-c-ht
branch
3 times, most recently
from
16e69fa
to
0c9d6f5
Compare
svenklemm
approved these changes
May 15, 2024
Comment on lines
+59
to
+74
| SELECT relname, relreplident FROM pg_class WHERE relname = 'test1' ORDER BY relname; | ||
| relname | relreplident | ||
| ---------+-------------- | ||
| test1 | f |
There was a problem hiding this comment.
Can u run it before and after changing the replica identity to make evident that it changed properly.
There was a problem hiding this comment.
I guess you only forgot to also run the check for the hypertable itself before changing the replica identity like you did for chunks. Other than that LGTM!
| (1 row) | ||
|
|
||
| -- the chunk's setting should also change to FULL | ||
| SELECT relname, relreplident FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) ORDER BY relname; |
There was a problem hiding this comment.
Suggested change
| SELECT relname, relreplident FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) ORDER BY relname; | |
| SELECT relreplident, COUNT(*) FROM show_chunks('test1') ch INNER JOIN pg_class c ON (ch = c.oid) GROUP BY 1 ORDER BY 1; |
Decrease the test output size... also be good to run it before and after change the replica identity.
JamesGuthrie
force-pushed
the
jg/replident-c-ht
branch
from
0c9d6f5
to
e24d54e
Compare
fabriziomello
approved these changes
May 15, 2024
JamesGuthrie
force-pushed
the
jg/replident-c-ht
branch
from
e24d54e
to
c1c2fcc
Compare
This unblocks the execution of `ALTER TABLE ... REPLICA IDENTITY ...` on hypertables with compression enabled. The configured replica identity only propagates to tables belonging to the uncompressed hypertable. Fixes: #6158
JamesGuthrie
force-pushed
the
jg/replident-c-ht
branch
from
c1c2fcc
to
cd04a4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.