Skip to content

Add rsync_options parameter to syncback #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pedantic-git
Copy link
Contributor

This adds a parameter to the syncback extension that allows specifying of any rsync options for more advanced usage. Right now I'm using it to work around #567 with the following code:

syncback('sync lockfiles', 'deploy/name-pn', '/rails/', 
  rsync_options=[
    '--include=db/', '--include=db/schema.rb',
    '--include=Gemfile.lock', '--include=yarn.lock', '--exclude=*'
  ]
)

but I imagine it could be used for all kinds of other advanced usage. I'm still up for attempting to write the more user-friendly solution to #567 if that's of interest too.

@nicksieger
Copy link
Member

Works for me, thanks! Can you re-push a commit with a Signed-off-by: Name <[email protected]> line in the message to satisfy the DCO check?

@pedantic-git pedantic-git force-pushed the feature/syncback-rsync-options branch from df618f9 to f0f4ea4 Compare April 10, 2024 16:57
@pedantic-git
Copy link
Contributor Author

Ooh sorry for missing that! I've re-pushed with that signoff.

@nicksieger nicksieger merged commit ed00031 into tilt-dev:master Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants