Support a custom collection of TLPHAssets #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Support a custom collection of TLPHAssets which doesn't belong to the photo library. - Choose the custom collection by default if it's available. - Changed TLPHAsset from struct to class to become reference type. - Added localIdentifier to TLPHAsset for direct comparing. - Updated TLPhotosPickerViewControllerDelegate for complex callbacks. - Set picker's navigationBar.isTranslucent to false by default.
|
Just sent another commit de814ef👇. Now we can swipe horizontally to select/deselect images, like iOS 11 built-in albums. |
- Support swipe horizontally to select/deselect images. - Added a configure setting to turn off selection animation. - Let collection view always bounce vertically.
jwd-ali
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It may be not what you want, and I broke the APIs of TLPhotosPickerViewControllerDelegate.
Here's a brief list of changes in the commit of eef1c6c: