Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add historic and castle_type tags #1927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rwrx
Copy link
Contributor

@rwrx rwrx commented Sep 30, 2019

Add historic and castle_type tags

@nvkelso
Copy link
Member

nvkelso commented Sep 30, 2019

Tell me more about this request?

Usually we'd insert something like castle_type into kind_detail instead of adding a new key.

Historic seems pretty wide, we'd probably want to map the values to new kinds?

@rwrx
Copy link
Contributor Author

rwrx commented Oct 1, 2019

We have created a style similar to OpenTopoMap which also shows palaces, for example this one: https://www.openstreetmap.org/way/38975518 and we didn't have any possibility to filter these buildings because we cannot find these data into vector-datasource. We don't know how to add this correctly into vector-datasource so we tried this. How can I add this properly into vector-datasource?

@nvkelso nvkelso added this to the v1.9.0 milestone Nov 11, 2019
@rwrx rwrx mentioned this pull request Mar 21, 2022
@@ -19,7 +19,9 @@ globals:
building_levels: {col: "building:levels"}
building_min_levels: {col: "building:min_levels"}
building_material: {col: "building:material"}
castle_type: {col: castle_type}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be better to put into a kind_detail value, with an allowlist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, I can do it. But I am not sure how. It is a very long time when I was changing it, so I cannot remember how this could be done. Thank you.

height: {col: height}
historic: {col: historic}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What values are present here in historic? Should they be turned into specific kind values instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure, I can do it. But I am not sure how. It is a very long time when I was changing it, so I cannot remember how this could be done. Thank you.

@nvkelso nvkelso modified the milestones: v1.9.0, v2.0.0 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants