-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build ordering and mem requirements for tiles via a --tile-specifier-file optional param #71
Open
tgrigsby-sc
wants to merge
23
commits into
master
Choose a base branch
from
travisg/20210415-add-build-ordering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
April 20, 2021 19:34
255344d
to
10b4769
Compare
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
April 20, 2021 19:35
10b4769
to
a4901c0
Compare
Looks good so far. |
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
April 23, 2021 00:05
3cd0e4d
to
87c4ba3
Compare
tgrigsby-sc
changed the title
WIP: Add build ordering and mem requirements for tiles via a --tile-specifier-file optional param
Add build ordering and mem requirements for tiles via a --tile-specifier-file optional param
Apr 23, 2021
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
April 26, 2021 21:57
0818757
to
ffd4b9e
Compare
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
May 7, 2021 21:47
9149231
to
6d99e95
Compare
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
May 7, 2021 21:54
6d99e95
to
5b7e092
Compare
tgrigsby-sc
force-pushed
the
travisg/20210415-add-build-ordering
branch
from
May 18, 2021 23:05
8ce9f99
to
1a6469d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a WIP This works - verified manually with last tile build. I want to try one full build before I call this done which I will do next week.
--tile-specifier-file
param tomake_meta_tiles.py
that points to an ordering fileTileSpecifier
that uses the tile specifier file to dictate ordering and memory requirements of a list of tilesenqueue_tiles
to make 1 call per job totilequeue_batch_enqueue
instead of a single call.enqueue_tiles
to override every job with it's requested memory numberTileSpecifier
creation exceptions by falling back to a no-op default