Skip to content

Conversation

@oraluben
Copy link
Collaborator

@oraluben oraluben commented Dec 25, 2025

Related to: #1504

Also remove toolchain version from Github Action cache key, it turns out that different cuda version can share same cache and get similar speedup: https://github.com/tile-ai/tilelang/actions/runs/20498276657/job/58901369419?pr=1532

Summary by CodeRabbit

  • Chores
    • Expanded build matrix to produce binaries with CUDA 13.1 on additional platforms, including ARM64 systems running Ubuntu 24.04.
    • Simplified build caching/keying to improve cache consistency and reduce restore overhead during builds.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the TileLang project.

Please remember to run pre-commit run --all-files in the root directory of the project to ensure your changes are properly linted and formatted. This will help ensure your contribution passes the format check.

We appreciate you taking this step! Our team will review your contribution, and we look forward to your awesome work! 🚀

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 25, 2025

📝 Walkthrough

Walkthrough

Added CUDA-13.1 entries to the GitHub Actions wheel build matrix for ubuntu-latest and ubuntu-24.04-arm, and simplified ccache keys by removing the toolkit component from primary and restore keys for the build-wheels job.

Changes

Cohort / File(s) Summary
CI/CD Workflow Configuration
.github/workflows/dist.yml
Added two matrix entries for CUDA-13.1 builds (ubuntu-latest, ubuntu-24.04-arm) and simplified ccache primary/restore key scheme by removing the matrix.toolkit component for build-wheels.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • LeiWang1999

Poem

🐰 I hop where CI workflows hum and run,
New CUDA-13.1 shines beneath the sun,
ARM joins the dance, cache keys trimmed with care,
Wheels spin anew — I twitch my whiskers in the air. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title '[Release] Build tilelang against CUDA 13.1 in CI' directly matches the main changeset, which adds CUDA 13.1 build matrix entries to the CI workflow configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ff1606 and b6bc528.

📒 Files selected for processing (1)
  • .github/workflows/dist.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/dist.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Quick Lint
  • GitHub Check: Build wheels for Python 3.9 on macos-latest with Metal
  • GitHub Check: Build wheels for Python 3.9 on ubuntu-latest with CUDA-13.1
  • GitHub Check: Build SDist
  • GitHub Check: Build wheels for Python 3.9 on ubuntu-24.04-arm with CUDA-12.8
  • GitHub Check: Build wheels for Python 3.9 on ubuntu-24.04-arm with CUDA-13.1
  • GitHub Check: Build wheels for Python 3.9 on ubuntu-latest with CUDA-12.8

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@oraluben oraluben requested a review from XuehaiPan December 25, 2025 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant