Skip to content

[BugFix] Add shuffle elect condition for ptx_arrive_barrier() in TMA barrier injection #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Rachmanino wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[BugFix] Add shuffle elect condition for ptx_arrive_barrier() in TMA barrier injection #1396

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e219d7
[BugFix] Add shuffle elect condition for ptx_arrive_barrier() in TMA …
Rachmanino Dec 10, 2025
6ffdf03
lint
Rachmanino Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/transform/inject_tma_barrier.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,23 @@ class TmaBarrierRewriter : public IRMutatorWithAnalyzer {
return IRMutatorWithAnalyzer::VisitStmt_(op);
}

Stmt VisitStmt_(const EvaluateNode *op) final {
// Check whether this is ptx_arrive_barrier()
if (const CallNode *call = op->value.as<CallNode>()) {
if (call->op.same_as(builtin::ptx_arrive_barrier())) {
// producer arrives → guard with tl_shuffle_elect()
if (has_warp_specialization_ && is_producer_) {
PrimExpr cond = Call(DataType::Bool(), tl_shuffle_elect(),
{IntImm(DataType::Int(32), 128)});
Stmt arrive_stmt = StmtExprMutator::VisitStmt_(op);
return IfThenElse(cond, arrive_stmt, Stmt());
}
}
}

return StmtExprMutator::VisitStmt_(op);
}

PrimExpr VisitExpr_(const CallNode *op) {
if (op->op.same_as(tma_load()) || op->op.same_as(tma_load_im2col())) {
auto call_ref = tvm::ffi::GetRef<Call>(op);
Expand Down
Loading