Add is_bottommost_level in compaction filter context
#374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
dco-signoff: yes
v01dstar
requested review from
LykxSassinator,
glorv,
overvenus and
SpadeA-Tang
LykxSassinator
approved these changes
Sep 23, 2024
|
@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
v01dstar
force-pushed
the
compaction-filter
branch
2 times, most recently
from
9d91c8d
to
1570d85
Compare
ti-chi-bot
bot
added
approved
size/L
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
compaction-filter
branch
from
1570d85
to
278e6d3
Compare
ti-chi-bot
bot
added
size/XS
Connor1996
approved these changes
Sep 26, 2024
|
/merge |
|
/approve |
LykxSassinator
approved these changes
Sep 26, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/merge |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of 8e20349
Adding
is_bottommost_levelinfo, so that MVCC storage engine built on top of RocksDB can decide whether to GC tombstones during compaction. i.e. If the compaction involves the bottommost level, tombstones can be discarded, otherwise, they need to be kept in order to GC old versions in the lower levels in the future.We had 2 other compaction filter related changes but are no longer needed now:
input_table_propertiesinCompactionFilter::Context