Add perf flag #373
Merged
Add perf flag #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
the
dco-signoff: yes
ti-chi-bot
bot
added
do-not-merge/work-in-progress
ti-chi-bot
bot
removed
the
do-not-merge/work-in-progress
v01dstar
requested review from
glorv,
LykxSassinator,
overvenus and
SpadeA-Tang
Signed-off-by: Yang Zhang <[email protected]>
ti-chi-bot
bot
added
size/L
|
/run-all-tests |
LykxSassinator
approved these changes
Sep 25, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Connor1996, LykxSassinator The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Adding
PerfFlag: Collect statistics for specific metrics while ignoring others to reduce performance overhead from excessive tracking. See PingCAP internal design doc.Each metric in
PerfContextandIOStatsContextis associated with a bit inPerfFlag, indicating whether to enable the collection of statistics for that specific metric. Any omissions (field exists inPerfContextorIOStatsContextbut does not exist inPerfFlag) will result in a compile-time error.