Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get table prop from table cache without IO #355

Closed
wants to merge 1 commit into from

Conversation

v01dstar
Copy link

@v01dstar v01dstar commented Feb 22, 2024

I confirmed with the author that the change no_io = false made in #211 was not intended as the PR description suggested.

If no_io is set to true, TableCache would not load the table and add it to the cache, when the table does not exist in the cache already, instead, the caller (in this case, Version which is then called by compaction) is responsible to load the table properties without affecting the cache. Since compaction is an one-off operation (from SST's perspective), it makes more sense to set no_io to true here.

Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v01dstar v01dstar closed this Oct 9, 2024
@v01dstar v01dstar deleted the fix-typo branch October 9, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants