proto: try to fix CI #565
Merged
proto: try to fix CI #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
Signed-off-by: lance6716 <[email protected]>
lance6716
commented
Aug 20, 2025
| // We use `default` method a lot to be support prost and rust-protobuf at the | ||
| // same time. And reassignment can be optimized by compiler. | ||
| #![allow(clippy::field_reassign_with_default)] | ||
| #![allow(mismatched_lifetime_syntaxes)] |
Contributor
Author
There was a problem hiding this comment.
add these lines because the generated protobuf code files raise warnings in CI
Contributor
Author
|
@Connor1996 @overvenus @gengliqi PTAL, thanks~ |
gengliqi
approved these changes
Aug 20, 2025
Contributor
Author
|
/cc @BusyJay |
Member
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master CI fails (you can see it at #564 )