Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: timing-based panic during prevote when using priority. #512

Closed
wants to merge 1 commit into from
Closed

Fix: timing-based panic during prevote when using priority. #512

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/raft.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ impl<T: Storage> RaftCore<T> {
if m.get_msg_type() == MessageType::MsgRequestVote
|| m.get_msg_type() == MessageType::MsgRequestPreVote
|| m.get_msg_type() == MessageType::MsgRequestVoteResponse
|| m.get_msg_type() == MessageType::MsgRequestPreVoteResponse
{
if m.term == 0 {
// All {pre-,}campaign messages need to have the term set when
Expand All @@ -629,16 +628,16 @@ impl<T: Storage> RaftCore<T> {
// - MsgPreVote: m.Term is the term the node will campaign,
// non-zero as we use m.Term to indicate the next term we'll be
// campaigning for
// - MsgPreVoteResp: m.Term is the term received in the original
// MsgPreVote if the pre-vote was granted, non-zero for the
// same reasons MsgPreVote is
fatal!(
self.logger,
"term should be set when sending {:?}",
m.get_msg_type()
);
}
} else {
} else if m.get_msg_type() != MessageType::MsgRequestPreVoteResponse {
// MsgPreVoteResp's term value reflects the current node's term.
// PreVote can happen when that value is 0 or later in the lifetime,
// so we don't enforce it's value.
if m.term != 0 {
fatal!(
self.logger,
Expand Down