Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/router: fix the incorrect deep copy method in QueryRegion #9080

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Feb 14, 2025

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Although #9055 identified the problem, the proposed fix is incorrect because the first request using the same region can still modify the data concurrently.
This PR resolves the issue by deep-copying the region from the response each time.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test

Before:

After:

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Feb 14, 2025
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 14, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 14, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-14 07:34:12.330636457 +0000 UTC m=+601094.726858519: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot added the approved label Feb 14, 2025
@JmPotato JmPotato force-pushed the fix_convertToRegionCopy branch from d97471c to 33db286 Compare February 14, 2025 12:47
Copy link
Contributor

ti-chi-bot bot commented Feb 14, 2025

@JmPotato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 33db286 link true /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants